[storage/qmdb] specialize the (common) k=2 case in apply_batch#3769
Draft
roberto-bayardo wants to merge 4 commits into
Draft
[storage/qmdb] specialize the (common) k=2 case in apply_batch#3769roberto-bayardo wants to merge 4 commits into
roberto-bayardo wants to merge 4 commits into
Conversation
Replace the 7-variant Phase state machine with a simpler 3-state enum and raw pointer traversal. The new Cursor operates on the linked list in-place instead of detaching visited nodes into a "past" accumulator and reattaching on Drop. Also fixes a minor bug in previous impl and adds a regression test.
Exercises the full Cursor lifecycle (next, find, delete, insert, drop) on every key, revealing the ~59% speedup from the Cursor simplification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 431da8c | May 12 2026, 10:39 PM |
Benchmark resultsTip ✅ PASSED: No benchmark exceeded the regression threshold. Benchmark comparison table
Baseline commit(s): |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## unsafe-index-2 #3769 +/- ##
===============================================
Coverage 95.81% 95.81%
===============================================
Files 472 472
Lines 187594 187629 +35
Branches 4443 4443
===============================================
+ Hits 179749 179783 +34
- Misses 6411 6413 +2
+ Partials 1434 1433 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
roberto-bayardo
force-pushed
the
unsafe-index-2
branch
from
15aeeff to
55ba772
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_batch/uncomm_ancestorapply_batch/comm_uncomm_chain